Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue-243 Updated HealthCheckResponse state property to status #257

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Issue-243 Updated HealthCheckResponse state property to status #257

merged 1 commit into from
Jun 4, 2020
+113 −31

Conversation

pgunapal
Copy link
Contributor

@pgunapal pgunapal commented Jun 3, 2020

Signed-off-by: Prashanth G pgunapal@ca.ibm.com

resolves #243

xstefank
xstefank approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, also verified with our impl.

api/src/main/java/org/eclipse/microprofile/health/HealthCheckResponseBuilder.java Outdated Show resolved Hide resolved
@pgunapal
Issue-243 Updated HealthCheckResponse state property to status
761dec0 
Signed-off-by: Prashanth G <pgunapal@ca.ibm.com>
@xstefank xstefank merged commit 10cc6e3 into eclipse:master Jun 4, 2020
@pgunapal pgunapal mentioned this pull request Jun 9, 2020
Closed
@antoinesd antoinesd mentioned this pull request Jun 17, 2020
Merged
@MikeEdgar MikeEdgar mentioned this pull request Sep 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xstefank xstefank xstefank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HealthCheckResponse deserialization issues
2 participants
@pgunapal @xstefank